Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

move up logic from CLI into local backend #1752

Merged
merged 1 commit into from
Jun 9, 2021
Merged

move up logic from CLI into local backend #1752

merged 1 commit into from
Jun 9, 2021

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jun 7, 2021

What I did
move up command logic on backend so that local backend do implement compose.API#Up

this removes reference to context type from cli package, so that this code is now independent from ACI/ECS/Kube backends

@github-actions github-actions bot added aci api api cli cli ecs kube Kubernetes backend local Local context (moby) labels Jun 7, 2021
@ndeloof ndeloof force-pushed the up_backend branch 9 times, most recently from 043d0a7 to 25f26e1 Compare June 7, 2021 17:01
@ndeloof ndeloof marked this pull request as ready for review June 7, 2021 18:28
ulyssessouza
ulyssessouza approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 2edec5a into docker-archive:main Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gtardif gtardif Awaiting requested review from gtardif

@lorenrh lorenrh Awaiting requested review from lorenrh

1 more reviewer

@ulyssessouza ulyssessouza ulyssessouza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aci api api cli cli ecs kube Kubernetes backend local Local context (moby)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndeloof @ulyssessouza